Author: kelnos
Date: 2006-07-30 21:18:41 +0000 (Sun, 30 Jul 2006)
New Revision: 22574
Modified:
xfce-utils/trunk/xfrun/xfrun-dialog.c
Log:
stuff from nick:
* use g_type_class_add_private() as a bit of an optimisation
* chain up to the parent's _finalize() - that should fix the last memleak.
note to self: when valgrind says there's memory lost on
g_type_create_instance(), this is usually why.
Modified: xfce-utils/trunk/xfrun/xfrun-dialog.c
===================================================================
--- xfce-utils/trunk/xfrun/xfrun-dialog.c 2006-07-30 20:29:23 UTC (rev
22573)
+++ xfce-utils/trunk/xfrun/xfrun-dialog.c 2006-07-30 21:18:41 UTC (rev
22574)
@@ -127,6 +127,8 @@
GObjectClass *gobject_class = (GObjectClass *)klass;
GtkWidgetClass *widget_class = (GtkWidgetClass *)klass;
+ g_type_class_add_private(klass, sizeof(XfrunDialogPrivate));
+
gobject_class->set_property = xfrun_dialog_set_property;
gobject_class->get_property = xfrun_dialog_get_property;
gobject_class->finalize = xfrun_dialog_finalize;
@@ -164,7 +166,8 @@
GtkTreeIter itr;
gchar *first_item = NULL;
- dialog->priv = g_new0(XfrunDialogPrivate, 1);
+ dialog->priv = G_TYPE_INSTANCE_GET_PRIVATE(dialog, XFRUN_TYPE_DIALOG,
+ XfrunDialogPrivate);
GTK_WINDOW(dialog)->type = GTK_WINDOW_TOPLEVEL;
gtk_widget_set_size_request(GTK_WIDGET(dialog), 400, -1);
@@ -295,7 +298,7 @@
if(dialog->priv->completion_model)
g_object_unref(G_OBJECT(dialog->priv->completion_model));
- g_free(dialog->priv);
+ G_OBJECT_CLASS(xfrun_dialog_parent_class)->finalize(object);
}
static gboolean
_______________________________________________
Xfce4-commits mailing list
[email protected]
http://foo-projects.org/mailman/listinfo/xfce4-commits
