Author: jannis
Date: 2008-11-20 00:06:52 +0000 (Thu, 20 Nov 2008)
New Revision: 28865

Modified:
   thunar/trunk/ChangeLog
   thunar/trunk/thunar/thunar-application.c
Log:
        * thunar/thunar-application.c (thunar_application_process_filenames):
          Always show an error dialog if one of the files passed via the
          command line cannot be opened. Required for exo-open to give proper
          visual feedback because spawning Thunar asynchronously will always
          make exo-open think that the file(s) were opened successfully.
          Ideally Thunar would display an error dialog with a tree view
          listing all the files that could not be opened (I'll file a bug for
          this).

Modified: thunar/trunk/ChangeLog
===================================================================
--- thunar/trunk/ChangeLog      2008-11-19 22:11:57 UTC (rev 28864)
+++ thunar/trunk/ChangeLog      2008-11-20 00:06:52 UTC (rev 28865)
@@ -1,3 +1,14 @@
+2008-11-20     Jannis Pohlmann <[EMAIL PROTECTED]>
+
+       * thunar/thunar-application.c (thunar_application_process_filenames):
+         Always show an error dialog if one of the files passed via the
+         command line cannot be opened. Required for exo-open to give proper
+         visual feedback because spawning Thunar asynchronously will always
+         make exo-open think that the file(s) were opened successfully.
+         Ideally Thunar would display an error dialog with a tree view
+         listing all the files that could not be opened (I'll file a bug for
+         this).
+
 2008-11-15     Jannis Pohlmann <[EMAIL PROTECTED]>
 
        * plugins/, tdb/, thunar-vfs/, thunar/: Fix several compiler warnings.

Modified: thunar/trunk/thunar/thunar-application.c
===================================================================
--- thunar/trunk/thunar/thunar-application.c    2008-11-19 22:11:57 UTC (rev 
28864)
+++ thunar/trunk/thunar/thunar-application.c    2008-11-20 00:06:52 UTC (rev 
28865)
@@ -1113,6 +1113,9 @@
   return TRUE;
 
 failure:
+  /* tell the user that we were unable to launch the file specified on the 
cmdline */
+  thunar_dialogs_show_error (screen, derror, _("Failed to open \"%s\""), 
filenames[n]);
+
   g_set_error (error, derror->domain, derror->code, _("Failed to open \"%s\": 
%s"), filenames[n], derror->message);
   thunar_file_list_free (file_list);
   g_error_free (derror);

_______________________________________________
Xfce4-commits mailing list
[email protected]
http://foo-projects.org/mailman/listinfo/xfce4-commits

Reply via email to