I have make the changes to __KEYBOARD() to restore the extended 
functionality we had before the new GT was imported from Harbour. Before 
I commit I need the group to consider.

This change will make xHarbour GT incompatible with Harbour GT so any 
synching with Harbour changes/bug fies will need to be done carefully.

I needed to change in hbgtcore.h

struct _HB_GT_BASE

line;
    BYTE *         StrBuffer;
to;
     int *       StrBuffer ;

which may require a CLEAN build and have implications for 3rd party 
developers.

The question is, is the group ok for me to commit the change?

Regards

Peter



Ron Pinkas wrote:
> Peter,
> 
> Any change that OVERRIDEs previous feature, and is not EXPLICITLY  
> agreed and documented to do so, must be considered circumstantial,  
> and should be re-implemented. This is even more important when we  
> lose feature as a side-effect of synching with some external code.
> 
> Please advise of every lost feature, you know of, or better yet,  
> commit needed revisions to re-implement. ;-)
> 
> Ron
> 
> On Mar 31, 2008, at 4:31 PM, Peter Rees wrote:
> The recent change to new GT means we have lost (amongst other things)
> the enhanced __KEYBOARD() function and are now are restricted to a
> maximum hb_set.HB_SET_TYPEAHEAD <= 4096 (Clipper compatible?).
> 
> e.g KEYBOARD { K_CTRL_C, "some string", K_CTRL_J } ...
>       __KEYBOARD( "some string", lAddToKeyboardBuffer )
> 
> HB_KEYPUT() has been enhanced to allow;
>     HB_KEYPUT( { K_CTRL_C, K_CTRL_J, ... } )
> but not;
>     HB_KEYPUT( { K_CTRL_C, "some string", K_CTRL_J } )
> 
> 
> I have followed the recent extended discussion on "dtoc enhanced" and am
> now reluctant to change anything in xHarbour for fear of breaking
> "Clipper" compatibility or seeing my time wasted by having changes
> overwritten by a future decision to be compatible with Harbour.
> 
> So what to do? I can make changes to my own xHarbour version but I'm not
> sure this is in the best interest of xHarbour or our users. I have been
> trying to use only standard xHarbour. With the change to GT I now HAVE
> to use a personal GTWVT.
> 
> 
> Regards
> 
> Peter
> 
> 
> 
> ------------------------------------------------------------------------ 
> -
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ 
> marketplace
> _______________________________________________
> xHarbour-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xharbour-developers
> 
> 
> 
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> xHarbour-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xharbour-developers
> 
> 


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
xHarbour-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xharbour-developers

Reply via email to