Miguel, Did you read my message?
1. The changes I suggested do NOT take away anything from what you just tried to explained, yet again. We understand that FTP will work faster with 64kb, and we have no problem if you set it to 64kb (in the FTP code). 2. We understand and agree that 1400 was awkward choice. Instead we prefer to use same size as the O/S default size, as reported by getsocketopt(). 3. *IF* you have any docs, or credible reference code, that explains that only 1/2 buffer size must be used, I suppose we'll have no objection with that either. Miguel, the above adjustments will NOT take away the improvements you made, speed of FTP will remain the SAME, as after your corrections. Ron On Apr 3, 2008, at 2:33 AM, Miguel Angel Marchuet wrote: I test actual cvs and it runs very high. Why other developers, don't want to test it with 64k buffer ? I'm working in other way. I was creating method at client class to access buffers, and then each protocol, can uses his own needed. How I explain in previous mails. for example FTP uses 64k by default for speed., but it can be modified by user. The rest of protocols uses default system. Remember to all people, that 1400 was a very big bug, because in some situations default buffer is lower than 1400, in this cases we was reading bad information from buffer. There are another important correction, is that we can't use full buffer to send files, because we can lost data (overlapping it). As other programs we use by default half buffer for security, and leave time to Inet API to empty buffer. All protocols will be corrected, for the moment only ftp was corrected. Best regards, Miguel Angel Marchuet Ron Pinkas escribió: > Maurilio, Miguel, > > <<< >> 1. Indeed we should not ASSUME any size, we should either: >> >> - Find if there's a way to QUERY, what's the O/S buffer size. >> > yes, there is, it is getsockopt(), which can tell you how big are OS > default > buffers. >>>> > > Miguel, please correct core implementation to use default O/S buffer > size, as reported by getsocketopt(), instead of the older hardcoded > 1400 bytes, or new 64KB. Then add to TFTP: > > #define FTP_SEND_BLOCKSIZE ... > #define FTP_RCV_BLOCKSIZE ... > ... > InetSetSndBufSize( pSocket, FTP_SEND_BLOCKSIZE ) > InetSetRcvBufSize( pSocket, FTP_RCV_BLOCKSIZE ) > > Ron > > > > ---------------------------------------------------------------------- > --- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ > marketplace > _______________________________________________ > xHarbour-developers mailing list > xHarbour-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xharbour-developers > ------------------------------------------------------------------------ - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ marketplace _______________________________________________ xHarbour-developers mailing list xHarbour-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xharbour-developers ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ xHarbour-developers mailing list xHarbour-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xharbour-developers
