Ron: > > SET ADS_LIB_VERSION=710 > This appears to be a mindless change - why would the define name NEED > to be changed?
I wouldn't characterize it as mindless, though by the time it was fully evolved it may not have *needed* to change but still might be better to change. I can see where having ADS_REQUIRE_VERSION maybe being one digit and maybe being 3 could create issues. The prior setup was based on the "whole number" and would have had to be translated to the new value, so the header would need the same chunk of code to determine "is this coming in the old way or the new way". I imagine seeing the old #define was the cleanest and easiest way to determine that, and to make sure that all instances of it got fixed to the new tests. I did not see all the evolutions as they occurred because I don't monitor that project; I believe also that there was an interim fix there where the old ADS_REQUIRE_VERSION had been converted to the 3 digit mode. Apparently there may have been some confusions with that to where a conversion to a new name was justified. I'm guessing at the details here. There is a compatibility section in the header that translates ADS_REQUIRE_VERSION to the new var, so that old users won't necessarily have to change their batch files to the new one, but it would be recommended for the better granularity. I'll ask if ultimately there's a technical reason why it can't get replaced by the old name, but at this stage trying to change it back would probably mean the two projects keeping different source code. -- Brian Hays Abacus Data Systems, Inc. > -----Original Message----- > From: Ron Pinkas [mailto:[EMAIL PROTECTED] > Sent: Tuesday, May 20, 2008 10:30 AM > To: Luis Krause Mantilla > Cc: [EMAIL PROTECTED]; bhays; 'xHarbour-Developers' > Subject: Re: [xHarbour-developers] RDDADS major cleanup > > > ADS_REQUIRE_VERSION becomes obsolete so you should not > > define it. Instead, you would use ADS_LIB_VERSION as in > > > > SET ADS_LIB_VERSION=700 > > or > > SET ADS_LIB_VERSION=710 > > > > depending if your users have 7.0 or 7.1 > > > > And then build rddads.lib > > This appears to be a mindless change - why would the define name NEED > to be changed? > > Ron > > No virus found in this incoming message. > Checked by AVG. > Version: 7.5.524 / Virus Database: 269.23.21/1456 - Release Date: > 5/20/2008 6:45 AM > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ xHarbour-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xharbour-developers
