Hello -

I've been evaluating xindice for a bit now and have been pretty impressed with 
it. I'm hoping to use xindice as a replacement for a rather horrid 
proprietary XML storage system at work.

As I've been reading the code, I've noticed that in most places where 
getLogger() is called the package of the class has been hardcoded. On other 
projects, I've preferred to use reflection to obtain the logger, so that any 
refactoring doesn't create inaccurate log messages. For example, I would do 
the following:

private static Log log = 
   LogFactory.getLog(SymbolSerializer.getClass().getPackage().getName());

instead of

private static Log log = LogFactory.getLog("org.apache.xindice.util");

I'd be willing to submit patches to fix this, if this is something that people 
would like to see done. I don't consider myself ready to participate in a 
real way (yet :), but these kinds of changes help me understand the code.

Thanks,
Kevin


Reply via email to