I took a second look at the system.xml file and where it gets loaded,
and that is indeed a better way.
I didn't do anything specific to work towards Dave Viner's comments
about configuring the XmlRpc messages, but elements I added should
permit those changes no problem:
<xindice>
...
<xml-rpc>
<driver name="..." />
...other xml-rpc configs...
</xml-rpc>
</xindice>
Attached find another untested patch. It's pretty ugly, the indentation
in that file is a mess. I am having trouble getting the
xmlrpc integration tests working, they error out with an NPE deep in
JUnit (error at the bottom of this email). I dunno what it is yet. The
unit and embedded integration tests work fine...
I have been looking at what it would take to write a unit test for the
XindiceServlet change, looks like I'd need to create/destroy a directory
in which to put a generated system.xml file. I've got a utility for
doing that... if you like I can donated it and add it to the test
heirarchy. Or, if anyone has a better idea how to run
servlet.init(ServletConfig) without going through all that, please let
me know...
Gary
The test was run against java 1.4.1 on linux.
------- junit failure in 'bin/ant test-integration-xmlrpc ------
Buildfile: build.xml
ZoneInfo: /usr/local/java/lib/zi/ZoneInfoMappings (No such file or
directory)
ZoneInfo: /usr/local/java/lib/zi/ZoneInfoMappings (No such file or
directory)
init:
src-build:
test-build:
test-validate:
[testClassValidator] TestClassValidator, by Vladimir R. Bossicard
[testClassValidator] Number of classes: 15
test-integration-xmlrpc:
[junit] Running org.apache.xindice.IntegrationXmlRpcTests
[junit] Exception in thread "main" java.lang.NullPointerException
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.PlainJUnitResultFormatter.endTest(PlainJUnitResultFormatter.java:208)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.PlainJUnitResultFormatter.formatError(PlainJUnitResultFormatter.java:245)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.PlainJUnitResultFormatter.addError(PlainJUnitResultFormatter.java:239)
[junit] at
junit.framework.TestResult.addError(TestResult.java:36)
[junit] at
junit.framework.TestResult.runProtected(TestResult.java:133)
[junit] at junitx.extensions.TestSetup.run(TestSetup.java:87)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:524)
[junit] TEST org.apache.xindice.IntegrationXmlRpcTests FAILED
BUILD SUCCESSFUL
Total time: 7 seconds
---------------------------------------------------------
On Wed, 19 Feb 2003, at 21:25 [-0700], Kimbro Staken ([EMAIL PROTECTED]:
> Did you look into using the existing Configurable system to pick up the
> setting from system.xml instead of adding a separate Properties object?
> I don't know if it will work or not, but if it does that's how it
> should be done.
>
> On Monday, February 17, 2003, at 10:09 PM, Gary Shea wrote:
>
> > I've been looking over how to configure the xml-rpc sax parser, which
> > is
> > now hard-configured to 'xerces'.
[snip...]
