BTW- I didn't change to re-throw, just increased the visibility in the
log.

-----Original Message-----
From: Vladimir R. Bossicard [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, July 15, 2003 10:09 AM
To: [EMAIL PROTECTED]
Subject: Re: Losing Exceptions

> FYI- There are many places in the code (> 60 times) where we
try/catch, 
> and do not throw.  To make matters worse, we only create a log
statement 
> when debug is on.

I don't know the specific try/catch you're talking about but sometimes 
you don't want to rethrow a caught exception (for example you want to 
return null and not an exception).  It's definitively a case-by-case 
problem.  We should definitively start javadocing the methods telling 
explicitely what's the behaviour when an error occurs.

> I'm in the process of changing the log.debug() to 
> log.warn() so there will be a better indication of any problems.

+1 (but not everywhere :-))

-Vladimir

-- 
Vladimir R. Bossicard
Apache Xindice - http://xml.apache.org/xindice

Reply via email to