Vadim Gritsenko wrote:
Interesting. Couple of patch formatting suggestions... (a) please use ALv2, Apache License version 2, as the rest of xindice sources, (b) please use 4 spaces instead of tabs. :-)
Noted :)
Sorry. As I read through the patch (after posting it!) it occured to me some comment might have been nice too :)
Now, about indexer itself... First, we need to get 1.1b4 out... For this, I'm planning to write some short doc about current XPath features - because XPath query result format was changed, and then I think 1.1b4 should be considered as ready. Once 1.1b4 is out, I can add your patch. Second, what are your plans on evolving this indexer. I think next logical step would be to discuss what text indexer pattern looks like (element/attribute, as for other indexers? or may be it should include path to element?), what should be query language (should it be lucene query language, or any additions to it?), and results should be (whole documents, or matching parts only? or configurable behavior?). What's your opinion?
Yes to all of that really. At the moment it's just scratching and itch for me but I'm happy to keep working on it. I'm certain it would be nicer if only the matching portions of documents were returned. If I was to make that configurable I'd imagine that to be a property of the query rather than the way Xindice is set up.
On the implementation I don't have a clear understanding of how Xindice achieves thread safe access to the indexes. I'm hoping that's something that's enforced at a fairly high level because all I'm doing is some fairly half hearted synchronization which woulnd't properly protect the Lucene index from concurrent attempts to update it and search on it. Perhaps you can advise?
-- Andy Armstrong, Tagish
