> On Wed, 14 Oct 2009, Oliver Stöneberg wrote:
> 
> > Thanks for the reply on my first mail. Here's a few more notes.
> > 
> > SMAILUtils.cpp
> > The function USmlExtractToAddress() is not used at all.
> 
> Right, by it stays.

Like the others just FYI.

> > SMTPSvr.cpp
> > In the function SMTPFilterMessage() a fflush() is performed before 
> > the fclose(). I think this is unncessary as fclose() implies a 
> > fflush() according to the manpage:
> > "The  fclose()  function will flush the stream pointed to by fp 
> > (writing any buffered output data using fflush(3)) and close the 
> > underlying file descriptor."
> 
> I know that, but I don't remember ATM why I split the two operations.
> I changed it now, and hopefully there was no real reason behind.

Maybe a faulty implementation on some distribution out there. I have 
read about some nasty fsync() bugs, so nothing is out of the 
question.

Any ETA on the first 1.27pre version?
_______________________________________________
xmail mailing list
[email protected]
http://xmailserver.org/mailman/listinfo/xmail

Reply via email to