Hi Lawrence,

On Monday 23 September 2002 8:32 pm, you wrote:

> I don't see any problem with including it.  Alastair?

There's a tiny bug in the -scale 2 YUV code which makes the colours look 
washed out - but that's easily fixed; as I said to Kingsley, when he spotted 
it:

> As for the colours being washed out at -scale 2: Well spotted!  To fix it, 
> remove the occurrences of /2 in lines 615, and 617, so they read:
>         u = (( -(5537)*r - (10878)*g + (16384)*b ) >> 15) + 128; \

>         v = (( (16384)*r - (13730)*g -(2664)*b ) >> 15 ) + 128; \

> and do the same for lines 657 and 659....

If you decide to include the current version, perhaps you'd make this 
change...

BTW - I have an updated version waiting in the wings, that maintains a YUV 
lookup table for the palette, where appropriate, and which allows one to 
force use of YUV over RGB with a command-line switch (Amazingly, this can 
actually be the faster option - and it should help on your Radeon!)
The lookup table required changes to sysdep_palette.* and video.c to 
re-instate the dirty flag that (I presume) used to be used for 8bpp support...

The only other thing I need to do to clean up the patch (and remove the word 
'dirty' from its description :^) is to make it actually "grab" the Xv port 
before using it - which shouldn't take too long.


On another note - have you been able to verify that you're using the latest 
version of GATOS on your Radeon?

I've successfully added RGB overlay support to the GATOS mach64 driver - and 
had to bug-fix the RGB overlay support in the Trident driver over the last 
few weeks - so it looks like where RGB overlay support is implemented, it's 
generally not well tested...

What I'd like to propose, is that I create a little testcard program using 
MPlayer's vidix drivers (a bit like DGA for overlays...), and see if they 
give correct RGB results on your card.  Unfortunately, the program would have 
to be run as root, so obviously I'll understand if you'd rather not :)

All the best,
-- 
Alastair M. Robinson
Email: [EMAIL PROTECTED]

User fell asleep while waiting.
 -- WindowError: 024

_______________________________________________
Xmame mailing list
[EMAIL PROTECTED]
http://toybox.twisted.org.uk/mailman/listinfo/xmame

Reply via email to