Author: jochen
Date: Fri Nov 28 12:36:45 2008
New Revision: 721556
URL: http://svn.apache.org/viewvc?rev=721556&view=rev
Log:
Eliminated some warnings.
Modified:
webservices/xmlrpc/trunk/client/src/main/java/org/apache/xmlrpc/client/XmlRpcStreamTransport.java
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/parser/RecursiveTypeParserImpl.java
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/RequestProcessorFactoryFactory.java
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/XmlRpcStreamServer.java
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/Connection.java
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServletServer.java
webservices/xmlrpc/trunk/tests/src/test/java/org/apache/xmlrpc/test/ClientIpTest.java
Modified:
webservices/xmlrpc/trunk/client/src/main/java/org/apache/xmlrpc/client/XmlRpcStreamTransport.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/client/src/main/java/org/apache/xmlrpc/client/XmlRpcStreamTransport.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/client/src/main/java/org/apache/xmlrpc/client/XmlRpcStreamTransport.java
(original)
+++
webservices/xmlrpc/trunk/client/src/main/java/org/apache/xmlrpc/client/XmlRpcStreamTransport.java
Fri Nov 28 12:36:45 2008
@@ -123,6 +123,14 @@
&& pConfig.isGzipCompressing();
}
+ /**
+ * Creates a new instance of [EMAIL PROTECTED] ReqWriter}.
+ * @throws XmlRpcException Creating the instance failed.
+ * @throws IOException Creating the instance failed, because
+ * an [EMAIL PROTECTED] IOException} occurs.
+ * @throws SAXException Creating the instance failed, because
+ * the request could not be parsed.
+ */
protected ReqWriter newReqWriter(XmlRpcRequest pRequest)
throws XmlRpcException, IOException, SAXException {
ReqWriter reqWriter = new ReqWriterImpl(pRequest);
Modified:
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/parser/RecursiveTypeParserImpl.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/parser/RecursiveTypeParserImpl.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/parser/RecursiveTypeParserImpl.java
(original)
+++
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/parser/RecursiveTypeParserImpl.java
Fri Nov 28 12:36:45 2008
@@ -55,6 +55,10 @@
factory = pFactory;
}
+ /**
+ * Called to start a value tag.
+ * @throws SAXException
+ */
protected void startValueTag() throws SAXException {
inValueTag = true;
text.setLength(0);
Modified:
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/RequestProcessorFactoryFactory.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/RequestProcessorFactoryFactory.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/RequestProcessorFactoryFactory.java
(original)
+++
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/RequestProcessorFactoryFactory.java
Fri Nov 28 12:36:45 2008
@@ -105,6 +105,7 @@
* }
* }
* </pre>
+ * @param pRequest The request object.
*/
protected Object getRequestProcessor(Class pClass, XmlRpcRequest
pRequest) throws XmlRpcException {
return Util.newInstance(pClass);
Modified:
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/XmlRpcStreamServer.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/XmlRpcStreamServer.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/XmlRpcStreamServer.java
(original)
+++
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/server/XmlRpcStreamServer.java
Fri Nov 28 12:36:45 2008
@@ -150,6 +150,7 @@
/** Called to prepare the output stream. Typically used for enabling
* compression, or similar filters.
+ * @param pConnection The connection object.
*/
protected OutputStream getOutputStream(ServerStreamConnection
pConnection,
XmlRpcStreamRequestConfig pConfig, OutputStream pStream) throws IOException {
@@ -162,6 +163,8 @@
/** Called to prepare the output stream, if content length is
* required.
+ * @param pConfig The configuration object.
+ * @param pSize The requests size.
*/
protected OutputStream getOutputStream(XmlRpcStreamRequestConfig
pConfig,
ServerStreamConnection pConnection,
@@ -170,6 +173,7 @@
}
/** Returns, whether the requests content length is required.
+ * @param pConfig The configuration object.
*/
protected boolean isContentLengthRequired(XmlRpcStreamRequestConfig
pConfig) {
return false;
Modified:
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/Connection.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/Connection.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/Connection.java
(original)
+++
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/Connection.java
Fri Nov 28 12:36:45 2008
@@ -59,7 +59,9 @@
private static final byte[] wwwAuthenticate =
toHTTPBytes("WWW-Authenticate: Basic realm=XML-RPC\r\n");
private static abstract class RequestException extends IOException {
+ private static final long serialVersionUID = 2113732921468653309L;
private final RequestData requestData;
+
RequestException(RequestData pData, String pMessage) {
super(pMessage);
requestData = pData;
Modified:
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java
(original)
+++
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java
Fri Nov 28 12:36:45 2008
@@ -29,8 +29,6 @@
import java.util.List;
import java.util.StringTokenizer;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.xmlrpc.server.XmlRpcStreamServer;
import org.apache.xmlrpc.util.ThreadPool;
@@ -72,8 +70,6 @@
* </pre>
*/
public class WebServer implements Runnable {
- private static final Log log = LogFactory.getLog(WebServer.class);
-
private class AddressMatcher {
private final int pattern[];
Modified:
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java
(original)
+++
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServlet.java
Fri Nov 28 12:36:45 2008
@@ -145,6 +145,8 @@
/** Creates a new instance of [EMAIL PROTECTED] XmlRpcServer},
* which is being used to process the requests. The default
implementation
* will simply invoke <code>new [EMAIL PROTECTED] XmlRpcServer}.
+ * @param pConfig The servlets configuration.
+ * @throws XmlRpcException
*/
protected XmlRpcServletServer newXmlRpcServer(ServletConfig pConfig)
throws XmlRpcException {
Modified:
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServletServer.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServletServer.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServletServer.java
(original)
+++
webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/XmlRpcServletServer.java
Fri Nov 28 12:36:45 2008
@@ -71,6 +71,9 @@
}
}
+ /**
+ * @param pRequest The request object.
+ */
protected XmlRpcHttpRequestConfigImpl newConfig(HttpServletRequest
pRequest) {
return new XmlRpcHttpRequestConfigImpl();
}
Modified:
webservices/xmlrpc/trunk/tests/src/test/java/org/apache/xmlrpc/test/ClientIpTest.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/tests/src/test/java/org/apache/xmlrpc/test/ClientIpTest.java?rev=721556&r1=721555&r2=721556&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/tests/src/test/java/org/apache/xmlrpc/test/ClientIpTest.java
(original)
+++
webservices/xmlrpc/trunk/tests/src/test/java/org/apache/xmlrpc/test/ClientIpTest.java
Fri Nov 28 12:36:45 2008
@@ -24,8 +24,6 @@
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-import junit.framework.Assert;
-
import org.apache.xmlrpc.XmlRpcException;
import org.apache.xmlrpc.XmlRpcHandler;
import org.apache.xmlrpc.XmlRpcRequest;
@@ -39,21 +37,40 @@
* Test case for reading the clients IP address.
*/
public class ClientIpTest extends XmlRpcTestCase {
+ /**
+ * An object, which provides additional information
+ * about the client to the user.
+ */
public static class ClientInfo {
private final String ipAddress;
+ /**
+ * Creates a new instance.
+ */
public ClientInfo(String pIpAddress) {
ipAddress = pIpAddress;
}
+ /**
+ * Returns the clients IP address.
+ */
public String getIpAddress() {
return ipAddress;
}
}
+ /**
+ * An extension of the [EMAIL PROTECTED] XmlRpcServlet}, which
+ * ensures the availability of a [EMAIL PROTECTED] ClientIpTest.ClientInfo}
+ * object.
+ */
public static class ClientInfoServlet extends XmlRpcServlet {
+ private static final long serialVersionUID = 8210342625908021538L;
private static ThreadLocal clientInfo = new ThreadLocal();
+ /**
+ * Returns the current threads. client info object.
+ */
public static ClientInfo getClientInfo() {
return (ClientInfo) clientInfo.get();
}
