Author: jochen
Date: Fri Nov 28 12:57:51 2008
New Revision: 721560
URL: http://svn.apache.org/viewvc?rev=721560&view=rev
Log:
The ThreadPool could create more threads than configured.
PR: XMLRPC-161
Submitted-By: Mark Gertsvolf <[EMAIL PROTECTED]>
Modified:
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java
webservices/xmlrpc/trunk/src/changes/changes.xml
Modified:
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java?rev=721560&r1=721559&r2=721560&view=diff
==============================================================================
---
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java
(original)
+++
webservices/xmlrpc/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java
Fri Nov 28 12:57:51 2008
@@ -155,7 +155,7 @@
* might consider to use the [EMAIL PROTECTED]
#addTask(ThreadPool.Task)} method instead.
*/
public synchronized boolean startTask(Task pTask) {
- if (maxSize != 0 && runningThreads.size() > maxSize) {
+ if (maxSize != 0 && runningThreads.size() >= maxSize) {
return false;
}
Poolable poolable;
Modified: webservices/xmlrpc/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/src/changes/changes.xml?rev=721560&r1=721559&r2=721560&view=diff
==============================================================================
--- webservices/xmlrpc/trunk/src/changes/changes.xml (original)
+++ webservices/xmlrpc/trunk/src/changes/changes.xml Fri Nov 28 12:57:51 2008
@@ -28,6 +28,10 @@
issue="XMLRPC-162">
Eliminated a possible race condition in the ThreadPool.
</action>
+ <action dev="jochen" type="fix" due-to="Mark Gertsvolf"
due-to-email="[EMAIL PROTECTED]"
+ issue="XMLRPC-161">
+ The ThreadPool could create more threads than configured.
+ </action>
</release>
<release version="3.1.1" date="2008-Aug-10">
