[
https://issues.apache.org/jira/browse/XMLRPC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720795#action_12720795
]
Jochen Wiedmann commented on XMLRPC-174:
----------------------------------------
> There is no "cost" for adding this because calling ".foo()" makes no sense in
> java. so as far
> as i understand we do not lose anything by removing the "." if the
> pRemoteName is empty.
Wanna propose a patch?
> The ClientFactory always concatenates a "." before the method name.
> -------------------------------------------------------------------
>
> Key: XMLRPC-174
> URL: https://issues.apache.org/jira/browse/XMLRPC-174
> Project: XML-RPC
> Issue Type: Bug
> Components: Source
> Affects Versions: 3.1.1
> Reporter: Livnat Peer
> Priority: Minor
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> I want to invoke a remote method, who's name is without any prefix.
> In the "newInstance" methods:
> 1. The first 2 signatures add the class name as a prefix:
> public interface X{
> public void foo();
> }
> foo() invokes--> X.foo()
> 2. The 3rd signature adds the string passed in pRemoteName as a prefix:
> invoking newInstance with pRemoteName="goo" invokes--> "goo.foo()"
> passing pRemoteName="" invokes
> --> ".foo()"
> suggested patch:
> In the class
> "ClientFactory.java"
> In method
> "public Object newInstance(ClassLoader pClassLoader, final Class pClass,
> final String pRemoteName)"
> add a check if the pRemoteName is empty, if this is the case then no need to
> concatenate "." before the method name.
> today - String methodName = pRemoteName + "." + pMethod.getName();
> a fix - String methodName = pMethod.getName();
> if(pRemoteName.length()>0){
> methodName = pRemoteName + "." + methodName;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
