Henri Gomez wrote:
Nobody to revue my GZIP patch and commit to HEAD ?
Henri, some comments:
1.) The "Accept-Encoding" header transmitted by the client seems to me to be RFC compliant, so that is fine.
However, if the server is simply looking for the word "gzip" in the header, that seems to me to be insufficient. For example, the following might be handled wrongly:
Accept-Encoding: gzip;q=0.0, identity; q=0.5, *;q=0
(I admit, that the example might be academic.) However, I'd recommend to change the patch allong the lines of
public static boolean isUsingGzipEncoding(String pHeaderValue) {
if (pHeaderValue == null) {
return false;
}
for (StringTokenizer st = new StringTokenizer(pHeaderValue,
",");
st.hasMoreTokens(); ) {
String encoding = st.nextToken();
int offset = encoding.indexOf(';');
if (offset >= 0) {
encoding = encoding.substring(0, offset);
}
if ("gzip".equals(encoding)) {
return true;
}
}
return false;
}2.) Any change, that you handle compression of the requests as well?
3.) Isn't your change worth a patch for the docs?
Jochen
