Hi All,
Yey. We've awaken a committer.
Very few patches are submitted with any form of tests or documentation, meet the coding conventions used at Apache, or contain an indication if the standard test suite has been run. This makes it difficult to accept them, as the submitters code already works without changes to XML-RPC, and significant effort is required from committers to develop tests so that other users of the code can have some degree of certainty that the code works.
So if I've submitted patches that meet the coding conventions, with a submitted Junit test, and is useful to others, I should submit them again? Or should I use JIRA for that?
Many of these patches might be better placed in a 'contrib' package, with less stringent guidelines regarding tests and the like. While they are often of use to their submitters, it is unclear (to me at least) if they are necessary (or usable) for other users of the package. A 'contrib' package would be a compromise approach. If it appears that there are a large number of users for a particular feature, then moving it to the core (and developing appropriate tests) can be considered.
Would preventing randomly thrown Exceptions when parsing bad/weird XML-RPC responses be considered "useful"? I don't want to get into a discussion about how everyone should adhere strictly to the spec. There are different interpretations of the spec, and I can't change everyone's interpretations of it. All I know is that I need the library to work with vendor X, and I think my changes would help anyone else who wants to work with vendor X.
I *have* been able to work around the problem by using the "sufficient support" in the current API you mentioned, until I ran into the encoding issue. Thanks for the patch.
--
Steve
------------------------------------------------------------
"Always ... always remember: Less is less. More is more. More is
better. And twice as much is good too. Not enough is bad. And too
much is never enough except when it's just about right."
-- The Tick
------------------------------------------------------------
