----- Original Message -----
From: "Jochen Wiedmann" <[EMAIL PROTECTED]>
To: <xmlrpc-dev@ws.apache.org>
Sent: Friday, October 21, 2005 9:35 PM
Subject: Re: [PATCH]Patches and additions to make HttpClient work with
Apache XML-RPC
[EMAIL PROTECTED] wrote:
I've made some additions/changes to get Commons HttpClient working
correctly
with Apache XML-RPC which I think can be helpful for others as well.
Given the facts that the CommonsXmlRpcTransportTest works quite fine and
that a real lot of people are using the CommonsXmlRpcTransport (me not
included, to be honest), I wonder what your patches are good for? I think,
there's some explanation required.
Jochen
Well, there were two of us at work that tried to get it to work but we could
not see how things were connected with the DefaultXmlRpcTransportFactory.
Then I realized that I don't think that DefaultXmlRpcTransportFactory can be
used to get instances of CommonsXmlRpcTransport. Or?
Did not think to search for a test. However, I had a look at the
CommonsXmlRpcTransportTest now and it does not seem to do much more than
call the constructor...? When on tests, have this projects considered to use
a code (test) coverage tool? My project uses Cobertura (cobertura.sf.net)
and are _very_ pleased with what it has done for us.
Anyway, as I mentioned initially that I forgot to use the CVS version of
CommonsXmlRpcTransport and therefore I added method for setting (read)
timeout and connection timeout (setTimeout and setConnectionTimeout).
However, I saw that the exact same method with the same javadocs (from
Commons HttpClient) had already been added, so my changes to
CommonsXmlRpcTransport probably does not have any value (or diffs other than
moving instance variables together).
It might be that the CommonsHttpClientXmlRpcTransportFactory is unnecessary
as well, but I did not get DefaultXmlRpcTransportFactory to do the job. Can
it be used? Specifically, I want a factory class for CommonsXmlRpcTransport
that I can set default timeout values on the factory object so that
CommonsXmlRpcTransport classes are created with these timeout values.
I don't like to take up your time like this. Think a lot of these
misunderstandings/uncertainties could have been eliminated if the
contribution documentation was more informative and information that is
out-of-date (CVS, Bugzilla, ...) was removed from home page.
That said, this project is something that I have much use for and I might be
able to give it some time since I am not currently working with any
open-source project and would like to do so.
Kind regards,
Jimisola
