The attached patch moves xmlSecMSCryptoNodeGetBigNumValue/ xmlSecMSCryptoNodeSetBigNumValue to xmlsec-core and removes the code in xmlSecMSCryptoKeysStoreFindKey function that caches keys in xmlsec-mscrypto default keys manager. This patch finishes the first code review pass :) And I think that we are in a pretty good shape! The tests suite succeeds for all but the following tests: A)
Not implemented transforms:
HMAC RSA-OAEP KW-TripleDES KW-AES[128|192|256] B) Failing tests: - merlin-xmldsig-twenty-three/signature-keyname Something about loading some dll, looks like a problem with my "cursed" box and don't worry about it too much. - merlin-xmlenc-five/encrypt-data-aes128-cbc Very strange error with decrypting the file encrypted a minute ago. - 01-phaos-xmlenc-3/enc-element-3des-kt-rsa1_5 01-phaos-xmlenc-3/enc-content-aes256-kt-rsa1_5 01-phaos-xmlenc-3/enc-element-aes128-kt-rsa1_5 01-phaos-xmlenc-3/enc-text-aes192-kt-rsa1_5 Problems loading private key? My nearest plans are: 0) Look into failing tests from section B) above; 1) Make a minor code cleanup in src/mscrypto/x509.c and src/mscrypto/certkeys.c to improve maintanability. 2) Do one more code review pass (weekend?) 3) Think about running xmlsec-mscrypto with a memory leak checker. 4) Test xmlsec-mscrypto on Windows 9x (?) After that I would be ready to merge the mscrypto branch to the trunk, do documentation, file bugs for non-implemented things and release version 1.2 :) Wouter, would do you think about that? What are your plans? Aleksey |
mscrypto5.diff.gz
Description: application/gzip
