Hi Sven,
I have to admit that I don't remember why I've changed this condition
from your original pull request. I suspect it caused issues on Windows
build. I wonder if we should change it to this:
#if !defined(WINAPI_FAMILY) || WINAPI_FAMILY != WINAPI_FAMILY_PHONE_APP
Best,
Aleksey
On 11/10/20 3:55 AM, Sven Paschukat wrote:
Hi Aleksey,
In Commit
_https://github.com/lsh123/xmlsec/commit/2d3998090f8882c3aea41ed77050961813ba3beb_
<https://github.com/lsh123/xmlsec/commit/2d3998090f8882c3aea41ed77050961813ba3beb>
you changed the (not) UWP condition to
#if !defined(WINAPI_FAMILY) || (WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP)
Are you sure that’s correct? To my understanding the WINAPI_FAMILY is
set to WINAPI_FAMILY_PHONE_APP on UWP, so building for UWP would direct
the compiler to LoadLibraryA, which is not accessible then. The previous
code
#if !defined(WINAPI_FAMILY) || WINAPI_FAMILY == WINAPI_FAMILY_DESKTOP_APP
looks better for me.
Regards,
Sven
_______________________________________________
xmlsec mailing list
[email protected]
http://www.aleksey.com/mailman/listinfo/xmlsec
_______________________________________________
xmlsec mailing list
[email protected]
http://www.aleksey.com/mailman/listinfo/xmlsec
