[even if it seems that your messages don't make it through, please keep the list in CC]
On 2015-01-04, Harald Brabenetz wrote: > I think the DiffBuilder is the right place, because CommentLessSource, > WhitespaceStrippedSource, WhitespaceNormalizedSource makes mostly > sense if they are used on Control- and Test-Source in the same way. "the right place" for specifying, that you want to ignore comments? The argument that I'll have to treat boths inputs the same is compelling. > But the Input.Builder could have the same implementation (maybe by an > AbstractBuilder implementation?). > ------------- > Diff & DiffBuilder. > ------------- > I'm now finished with Diff & DiffBuilder. I'll try to have a look and provide feedback soon. > ------------- > Input > ------------- > Valid inputs for control and test are all Objects supported by > Input.fromUnknown(Object). >From the sound of it I'm not fond of fromUnknown but will first look at the code before commenting any further. > Also I implemented the Method Input.fromJaxb(Object) with the same > default marshaller rules from javax.xml.bind.JAXB (but with the > Input.Builder as Result). Ah, nice catch. Could you create a separate pull request just for the missing JAXBSource part? > ------------- > ComparisonFormatter => used in Diff.toString() > ------------- Again, I'll have to defer commenting until I've found time to look at the code. > I created UnitTestCases for each ComparisonType in > ComparisonFormatterDefaultTest. Only > ComparisonType.NO_NAMESPACE_SCHEMA_LOCATION I couldn't reproduce: I > got only ComparisonType.ATTR_VALUE: > Diff diff = DiffBuilder.compare( > "<a > xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"; " > + "xsi:noNamspaceSchemaLocation=\"Book.xsd\"/>", there is a typo in the attribute name - a missing "e" in Nam*e*space. Cheers Stefan ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ Xmlunit-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xmlunit-general
