Looks great!

I only don't understand the SystemProperty "testresourcebasedir" 
("test_Constants.java" line 48):
    public static final String BASEDIR = 
System.getProperty("testresourcebasedir");
My IDE doesn't have this Property per Default. I would simply hard code it:
    public static final String BASEDIR = new File("..").getAbsolutePath();
But I think you have some plans with this property according to the shared 
test-resources with .NET you mentioned.

The "mvn javadoc:aggregate" command already generates an overall Javadoc into 
"target/site/apidocs".
http://maven.apache.org/plugins/maven-javadoc-plugin/examples/aggregate.html#Using_The_aggregate_Goals

with friendly regards,
Harald

> Gesendet: Samstag, 10. Januar 2015 um 14:59 Uhr
> Von: "Stefan Bodewig" <[email protected]>
> An: [email protected]
> Betreff: [Xmlunit-general] Build Using Maven
>
> Hi all
> 
> the maven branch[1] now builds using Maven.  It is a combination of
> Harald's branch and ideas of my own based on Sonatype's parent.  I've
> uploaded 2.0.0-SNAPSHOTs to [2] in order to verify the build.
> 
> Right now the Travis build fails (for Java6 and 7, not for 8) inside the
> legacy tests, I'll need to look into that.  I also want to add the
> "sumo" jar of the Ant build and need some way to create the overall
> javadocs.  And finally I want to extract the test resources in order to
> share them between Java and .NET (which is in a repo of its own by now).
> 
> But before I wade in even further, I'd appreciate any feedback.
> 
> Cheers
> 
>         Stefan
> 
> [1] https://github.com/xmlunit/xmlunit/tree/maven
> [2] https://oss.sonatype.org/content/repositories/snapshots/org/xmlunit/
> 
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> Xmlunit-general mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xmlunit-general
> 

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Xmlunit-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xmlunit-general

Reply via email to