Hi I'll try to come up with a branch that splits "stop diffing" out of the "this is the comparison's result" logic of DifferenceEvaluator. I'm going to borrow your Difference class for this.
On 2015-01-18, Harald Brabenetz wrote: > All changes for implementing DiffBuilder and ComparisonFormatter so far: > https://github.com/brabenetz/xmlunit/commit/f4408ea23eca8afaff28b5b11dfea6bc67735f4e I'd use DefaultComparisonFormatter rather than ComparisonFormatterDefault, cosmetics. I better stop quibbling about details. > "DifferenceEvaluators.sequence(...)" (I has updated the > DifferenceEvaluatorsTest in the next commit): > https://github.com/brabenetz/xmlunit/commit/cd88ac571d72582451a59f21b7a8cdffbff8b903 Looks good, I'd only have issues with naming (in particular of the test case ;-) > DiffBuilder.withDifferenceEvaluators(...) and > withDifferenceEvaluators.deactivateDefaultDifferenceEvaluator(): > https://github.com/brabenetz/xmlunit/commit/f05706c13a4d4a19602857b052971bb865f5ae06 Not sure about the NOTHING evaluator. Maybe it would be better to throw an exception if the user disabled the default evaluator and did not provide a DifferenceEvaluator explicitly. Cheers Stefan ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ Xmlunit-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xmlunit-general
