Hi

I've created a branch in order to experiment with separating the "do we
want to stop comparing" functionality from "how severe is this
difference".

https://github.com/xmlunit/xmlunit/compare/ComparisonController

The implementation in DifferenceEngine using Map.Entry is just a quick
hack, I didn't want to distract from the API change by refactoring
DifferenceEngine.

To me it feels cleaner to have them separate, it removed some clumsy
workarounds in DOMDifferenceEngineTest where a custom
DifferenceEvaluator delegated to DefaultStopWhenDifferent - of course at
the expense of other workarounds (the wrap methods).

The code in legacy's NewDifferenceEngine looks cleaner as well.

Stefan

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Xmlunit-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xmlunit-general

Reply via email to