Sergei Trofimovich [2010-01-12 00:44]: Hi,
> OTHED: sid: cppcheck: [./src/plugins/sid/sidplay_wrapper.cpp:184]:
> (possible error) Memory leak: rs
>
> Fixed ReSIDBuilder object leak in error paths.
> Thanks to cppcheck.
I think
OTHER: Fixed ReSIDBuilder object leak in error paths.
would make for a more useful summary line.
Same for the other patches.
> val = g_new0 (xmms_stream_type_val_t, 1);
> val->key = key;
>
> [...]
> break;
> default:
> XMMS_DBG ("UNKNOWN TYPE!!");
> + g_free (val);
> return NULL;
> }
IMO we shouldn't allocate anything if the type isn't supported.
Regards,
Tilman
--
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
pgps7lcVUIEvk.pgp
Description: PGP signature
-- _______________________________________________ Xmms2-devel mailing list Xmms2-devel@lists.xmms.se http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel
