> On Sun, Mar 21, 2010 at 11:54 AM, Adam Nielsen <a.niel...@shikadi.net> wrote: >> I just have one question. In the XX_plugin_setup() function there doesn't >> seem to be any way to attach private data to the plugin instance, like >> xmms_xform_private_data_set() does for xform instances. This means I am >> using >> global variables to track the number of dynamic config options. Is that >> correct or could it cause problems? > > iirc that will cause problems as it's possible to play a song, while > extracting metadata from a song of the same time. thus having > 1 > instances of an xform alive from different threads at the same time.
That should be OK as the xform instance (created with init/destroy) stores private data so multiple xform instances will work, but will there ever be multiple plugin instances? i.e. will the xmms_XX_plugin_setup() be called multiple times, as that's where I'm using the globals. On a related note, there doesn't seem to be a companion destroy function for the plugin_setup() function, is that correct? Or are you meant to register something with atexit() if you need to clean up? Thanks, Adam. -- _______________________________________________ Xmms2-devel mailing list Xmms2-devel@lists.xmms.se http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel
