Hi nano,
Here some comments about the stuff in nano/master on http://git.xmms2.org/merge/. # be37053 OTHER: Make xmms_object_(ref|unref) concrete. * The change to xform.c seems weird. Should that be part of a different commit? * Why does xmms_object_ref return the object, especially in the case that XMMS_IS_OBJECT is false? * It seems we were previously for create_tree depending on XMMS_OBJECT not doing anything. It's better now. * Otherwise looks good. # b0549c8 OTHER: Simplify freeing of indata. Looks good. # 51a3fc6 OTHER: Redirect xform indata_get* to out* from prev. Looks good. # 3eef798 OTHER: Cleanup out_type usage in xform. * API of xmms_xform_outdata_type_set is changing, but only used in one place, where it is compatible, * API of xmms_xform_outdata_type_copy changes, but only called in inits, where it looks sane. * Looks good. # d228d51 OTHER: xform_plugin_supports doesn't modify stream type. * Looks good. # 36afb2f OTHER: Add option to set out-type in xform setup func. * xmms_xform_plugin_outdata_type_add sounds like it can be called several times. However, it overrides out_type. Perhaps this should be called _set? * To make sure I got this straight: xform_plugin_ts exist forever, and are used to get xform_ts. If the xform_t didn't get its out_type set then we use the one from xform_plugin_t. * Could you rename xform_plugin_t's out_type to default_out_type or somesuch? * Is this being used anywhere? # 2516cf0 OTHER: Don't require xforms to have an init function. Looks good. # 1389f5d OTHER: Fix a really old copy/paste style issue Looks good. # ee0c7e8 OTHER: Add test for broken idlist_to_playlist. * Perhaps xmms_plugin_shutdown should be called in CLEANUP instead. * Add docs for xform_browse_add_symlink(_args)?. # 3032c81 BUG(2593): Don't free "realpath" before use in idlist_to_playlist. * I think I'd move the ref before the get_string. * Otherwise looks good. # 095f9b7 OTHER: Simplify setup for playlist plugins. * Delete xmms_cue_init altogether. * Otherwise looks good. # dc8249b OTHER: Update travis config. * No idea about this. * I prefer "use" over "utilize". * No newline at file's end. # 511b575 / 80ee100 / 33e9590 more pkgs via apt addon * No idea about this. * Fix commit message. * Squash together? * Squash into "OTHER: Update travis config."? Cheers, Erik -- _______________________________________________ Xmms2-devel mailing list Xmms2-devel@lists.xmms2.org http://lists.xmms2.org/cgi-bin/mailman/listinfo/xmms2-devel
