Hearing no further objections to my latest branch commits...

http://github.com/grempe/xmpp4r/commits/errors

Lucas, OK for me to merge this to master?

Cheers,

Glenn

On Jun 10, 2008, at 1:28 AM, Matt Palmer wrote:

On Tue, Jun 10, 2008 at 08:44:04AM +0100, Brian Candler wrote:
On Mon, Jun 09, 2008 at 06:21:23PM -0700, Glenn Rempe wrote:
All errors classes would be subclassed from JabberError which itself
is sub-classed from RuntimeError

Would it be better to subclass from StandardError instead? This is so that it's easier to distinguish between Jabber errors and user exceptions like
raise "Oops, something went wrong"

I'd vote in favour of subclassing from StandardError.  I'm pretty sure
that's how it's supposed to be done, given that all other "common"
exceptions are subclassed from StandardError.

- Matt

_______________________________________________
Xmpp4r-devel mailing list
[email protected]
https://mail.gna.org/listinfo/xmpp4r-devel

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Xmpp4r-devel mailing list
[email protected]
https://mail.gna.org/listinfo/xmpp4r-devel

Reply via email to