On Fri, Feb 13, 2009 at 10:02 AM, Paulo Cesar Pereira de Andrade <[email protected]> wrote: > When setting the variable value using `pkg-config --variable` > it causes make distcheck to fail, and needing to circunvent the > problem by adding a configure option.
If you want to make this change, then do it in the other drivers, too. It doesn't make a big difference to me, but it should be consistent. However, acecad (and most of the drivers) doesn't actually use sdkdir. Only the drivers that install headers (evdev, synaptics?) care about sdkdir. So, you can just nuke it here. > This solution should be significantly cleaner, but a macro > in xorg-server.m4 could be a better approach, as it would be > required to change only that file once macros are used in > drivers. The macro in xorg-server.m4 would cause exactly the same problem as using pkg-config. The issue is that distcheck expects that all installed files will respect --prefix and install under that directory. If you install to an externally defined location (sdkdir from pkg-config or xorg-server.m4) then you cannot guarantee this condition. -- Dan _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
