Julien Cristau wrote:
> On Mon, Apr 20, 2009 at 14:12:50 +0200, Simon Thum wrote:
>
>> Julien Cristau wrote:
>>> v2: fixed the float handling for 64bit as Peter did for set-float-prop
>> [...]
>>> + union {
>>> + unsigned char *c;
>>> + short *s;
>>> + long *l;
>>> + Atom *a;
>>> + } data;
>> Wouldn't it be necessary to store Atoms long-aligned as well ?
>> (disclaimer: I did't look up the Atom definition, nor associated specs)
>>
> On the client side, Atom is unsigned long, so that should be ok.
>
> One thing I'm wondering is if I should be more paranoid and also check
> that format is 32 when type is FLOAT or ATOM.
I'd say if the server does 'enforce' it, that's enough. We depend on a
sane server anyway :)
Maybe put some warning.
Cheers,
Simon
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel
