About this "forcing all rendering to be transformed, even if you can do rotation in hardware"...isnt' this exactly what happens in the case where we don't use set_mode_major? Why have differing expectations between the two?
-----Original Message----- From: Daniel Stone [mailto:[email protected]] Sent: Wednesday, May 13, 2009 10:39 AM To: Defnet, Benjamin R Cc: [email protected]; Barnes, Jesse; Packard, Keith Subject: Re: xserver patch - Fix xf86CrtcSetModeTransform() to not skip transform processing with KMS [xorg@ dropped from Cc.] Hi, On Wed, May 13, 2009 at 09:44:50AM -0700, Defnet, Benjamin R wrote: > Fix xf86CrtcSetModeTransform() to properly process required rotation and > transformation data, even when using kernel mode setting. Previously, with > kernel mode setting enabled, this function just called set_mode_major() and > returned causing transformations to never be applied. > > This is my first time submitting a patch so please let me know if I'm not > doing this right. No, because this forces all rendering to be transformed, even if you can do rotation in hardware (cf. OMAP) and don't need any transformations applied. Why not just factor out the transformation into a helper function (or helper functions?). Also, as Maarten pointed out, set_mode_major isn't exclusive to KMS. Cheers, Daniel _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
