Michel Dänzer wrote: > On Wed, 2009-07-08 at 09:18 -0700, Eric Anholt wrote: >> New commits: >> commit 40e7c9505265823786cf730214db84812a5e494e <snip> >> + /* Fail very large allocations on 32-bit systems. Large BOs will >> + * tend to hit SW fallbacks frequently, and also will tend to fail >> + * to successfully map when doing SW fallbacks because we overcommit >> + * address space for BO access. >> + * >> + * Note that size should fit in 32 bits. We throw out >32767x32767x4, >> + * and pitch alignment could get us up to 32768x32767x4. >> + */ >> + if (sizeof(unsigned int) == 4 && >> [...] > > FWIW, this test is true on 64-bit systems as well. > > Deeper in the code, we assume that size always fits in an unsigned long (drm_intel_bo_alloc_for_render). I suspect that changing unsigned int to unsigned long is Good Enough? -- Simon Farnsworth
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
