Hi, On Tue, Sep 08, 2009 at 10:09:43AM +1000, Peter Hutterer wrote: > AlwaysCore and SendCoreEvents specify whether a device is to send core > events. A device that has either disabled is not supposed to send core > events. > > With MPX/XI2, a device that is attached automatically sends core events when > the event is routed through the master device. Floating a slave device > disables core events by breaking the route. > > This patch automatically floats devices that have coreEvents disabled in the > xorg.conf/HAL. This replicates the behaviour of a SendCoreEvents "false" > device in server 1.6 and earlier. > > The devices may still be reattached to a master at runtime. > > Signed-off-by: Peter Hutterer <[email protected]>
Acked-by: Daniel Stone <[email protected]> (comment below) > @@ -2357,7 +2360,13 @@ AttachDevice(ClientPtr client, DeviceIntPtr dev, > DeviceIntPtr master) > */ > if (!master) > { > - WindowPtr currentRoot = dev->spriteInfo->sprite->spriteTrace[0]; > + WindowPtr currentRoot; > + > + if (dev->spriteInfo->sprite) > + currentRoot = dev->spriteInfo->sprite->spriteTrace[0]; > + else > + currentRoot = WindowTable[0]; > + > /* we need to init a fake sprite */ > screen = currentRoot->drawable.pScreen; > screen->DeviceCursorInitialize(dev, screen); Should this hnk go in as a separate fix though? Should we maybe just add a GetDeviceSpriteWindow helper function that does this for us? Cheers, Daniel
pgpI1JVnviMG2.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
