Hi! On Sun, 2009-09-27 at 11:18:37 -0700, Alan Coopersmith wrote: > As noted in the discussion on > http://bugs.freedesktop.org/show_bug.cgi?id=24173 > we could simplify the setup in components like libX11 when using silent rules > if we used AM_V_GEN for all custom rules, like using cpp to generate files. > > Right now I've been putting in the custom rules, so silent mode prints: > CPP Compose > > Where AM_V_GEN would print > GEN Compose > > (for "generic" or "generate" I guess) - is the extra level of detail in > knowing > if it's cpp or sed or whatever useful? Or is "GEN" enough, since when you > need to debug you'll set V=1 anyway?
I personally prefer the more detailed output, but that's just me. OTOH to reduce a bit the setup needed on other components (no need to touch configure.ac nor conditionalize the verbosity variables), the attached patch could be used. regards, guillem
>From 03f3bd5bcef218ca9515a39dab99a4c2645d67d0 Mon Sep 17 00:00:00 2001 From: Guillem Jover <[email protected]> Date: Sun, 27 Sep 2009 21:32:45 +0200 Subject: [PATCH] Make sure AM_DEFAULT_VERBOSITY is always defined When there's no AM_SILENT_RULES support, set a AM_DEFAULT_VERBOSITY variable to 1 (verbose), so that the custom verbosity variables used in Makefile.am become no-ops. --- xorg-macros.m4.in | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index 8875193..be67a42 100644 --- a/xorg-macros.m4.in +++ b/xorg-macros.m4.in @@ -454,7 +454,8 @@ else fi fi AC_SUBST(CWARNFLAGS) -m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])], + [AC_SUBST([AM_DEFAULT_VERBOSITY], [1])]) ]) # XORG_CWARNFLAGS # XORG_STRICT_OPTION -- 1.6.4.3
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
