On Sat, 2009-10-03 at 08:43 -0400, Thomas Dickey wrote: > On Sat, 3 Oct 2009, Michel Dnzer wrote: > > > What purpose is that? If these functions were actually called with a > > NULL PixmapPtr, surely the current code would have crashed with a > > segmentation fault. > > I suppose that if you prefer the server to crash rather than check error > conditions, there's no point in the change.
I'd expect ModifyPixmapHeader getting called with a NULL PixmapPtr to always be a bug in the caller. I'd rather catch and fix that than cover it up. Maybe I'm missing something. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
