On Mon, 2009-10-05 at 19:08 -0500, Yaakov (Cygwin/X) wrote:

> Cygwin has O_NOCTTY but no TIOCSCTTY, so the tty is never made 
> controlling.  This raises two questions:
> 
> 1) What is the point of O_NOCTTY if TIOCSCTTY is called right afterwards?

Hah!  Can't think of one.

> 2) If there is a good reason for that, we could patch it:
> 
> +#ifdef __CYGWIN__
> +    tty = open(line, O_RDWR);
> +#else
>       tty = open(line, O_RDWR | O_NOCTTY);
> +#endif

That should be fine.

- ajax

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to