On Wed, 2009-10-07 at 10:42 -0700, Keith Packard wrote: > Excerpts from Jamey Sharp's message of Wed Oct 07 09:07:03 -0700 2009: > > Signed-off-by: Jamey Sharp <[email protected]> > > --- > > I don't know much about Xv or have any idea how to test this, but surely > > this loop is broken without this patch? > > > > Xext/xvdisp.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c > > index 04cd11a..5229916 100644 > > --- a/Xext/xvdisp.c > > +++ b/Xext/xvdisp.c > > @@ -1912,7 +1912,7 @@ void XineramifyXv(void) > > if((pAdapt->type & XvImageMask) && (pAdapt->nImages > 0)) { > > hasOverlay = FALSE; > > for(l = 0; l < pAdapt->nAttributes; l++) { > > - if(!strcmp(pAdapt->name, "XV_COLORKEY")) { > > + if(!strcmp(pAdapt->pAttributes[l].name, "XV_COLORKEY")) { > > hasOverlay = TRUE; > > break; > > } > > Looks reasonable to me; anyone with an overlay who might test this patch?
I don't have a setup like that handy, but the code as is is clearly wrong. Acked-by: Adam Jackson <[email protected]> - ajax
signature.asc
Description: This is a digitally signed message part
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
