On 10/10/2009 03:44, Jeremy Huddleston wrote:
On Oct 9, 2009, at 11:13, Jon TURNEY wrote:The rootless extension now directly calls some Xplugin functions, and relies on types defined in Xplugin.h, which isn't very abstracted :-)This patch is a start at abstracting some of the Xplugin specific stuff which has crept into rootlessWindow.c. This has been done in a pretty mindless fashion, without much thought as to if the additions to the generic rootless interface are the correct ones There is some confusion as to if RootlesscolormapCallback() returns a Bool or xp_error_enum value (not so abstact), but I have no way of checking, of finding out if Xplugin actually checks the result :-)Yes... erm... please don't breathe too hard when you look at miext/rootless. The condensation in your breath might cause it to all collapse... The RootlessColormapCallback bit is actually "correct" the way it was. Success == 0, and the failure != 0... so your patch actually inverts the returned value (something that caused me a few weeks of pain to debug) ... and yes, not patch in a particularly elegant way... See: http://cgit.freedesktop.org/xorg/xserver/commit/?id=8dd6d5c825d457f26b41b79d02d57ed4a5ecf1f5
Hmmm, I see.... how about the attached patch (incremental to my first one)
0001-Push-RootlessColormapCallback-down-into-XQuartz-DDX.patch
Description: application/itunes-itlp
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
