Re: [PATCH] Rootless: src drawable window can now be NULL

[Jeremy Huddleston]

That looks like a sane enough sanity check... but why was pSrc- >pDrawable NULL in the first place?

I'll check it out on XQuartz later today.

On Oct 13, 2009, at 01:45, Colin Harrison wrote:

Hi,

This is one for Jeremy Huddleston and Jon Turney.


to anti-alias).

Patch to fix the crash and make it work...

--- ./xserver/miext/rootless/rootlessScreen.c   2009-08-23
10:10:35.000000000 +0100
+++ ./test/miext/rootless/rootlessScreen.c      2009-10-13
09:34:49.000000000 +0100
@@ -257,8 +257,9 @@ RootlessComposite(CARD8 op, PicturePtr p
        maskWin = (pMask->pDrawable->type == DRAWABLE_WINDOW) ?
                  (WindowPtr)pMask->pDrawable :  NULL;
    }
-    srcWin  = (pSrc->pDrawable->type  == DRAWABLE_WINDOW) ?
-              (WindowPtr)pSrc->pDrawable  :  NULL;
+    if (!pSrc->pDrawable) srcWin = NULL;
+    else srcWin  = (pSrc->pDrawable->type  == DRAWABLE_WINDOW) ?
+                   (WindowPtr)pSrc->pDrawable  :  NULL;
    dstWin  = (pDst->pDrawable->type == DRAWABLE_WINDOW) ?
              (WindowPtr)pDst->pDrawable  :  NULL;

Thanks,
Colin Harrison

_______________________________________________
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel

Found when testing rootless modes in Xming using the new xeyes (uses Xrender

smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel