Hi, I think I addressed all comments from the first version, so here's v2. The first patch moves config_init(), AFAICT the hal backend still works with it.
Remaining question: - libudev doesn't give any error if it can't get to /sys or /dev/.udev/db, we just don't get any devices (this bit me when trying out this code in a chroot). Is this a libudev bug? Can we handle that better? Changes from v1: - move config_init() later in main() so we can get rid of the timer and add devices directly - share some code between the udev and hal backends - check for duplicate devices - move config/udev.c's global variables to the top of the file - configure.ac: move libudev requirement to a variable - xfree86: don't duplicate the log message for hal/udev - use udev_monitor_filter_add_match_subsystem_devtype to only monitor input events - use Xprintf instead of xalloc/sprintf - call udev_monitor_enable_receiving before udev_enumerate_scan_devices - indent with 4 spaces instead of tab - handle server/udev the same way as server/hal in kdrive and xfree86's NewInputDeviceRequest - turn "unhandled action" message from ErrorF to DebugF (we can also get "change" messages) _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
