Jeremy Huddleston wrote:
> Signed-off-by: Jeremy Huddleston <[email protected]>
>
> although this looks fishy to me:
>> XCONFIGFILEMAN='${XCONFIGFILE} (__filemansuffix__)'
>
> ...
>> -D__XCONFIGFILEMAN__='$(XCONFIGFILEMAN)'
>
> My brain isn't at 100% right now, so I can't recall if that's evaluated
> correctly. Since it impacts Xorg, I'm guessing you tested it though.
The single quotes keep the shell from doing anything with it, but make
will do substitutions of $() and ${} inside them, so the first line causes
the '${XCONFIGFILE} (__filemansuffix__)' string to be passed through unchanged
to the Makefile, where make will turn it into
-D__XCONFIGFILEMAN__='Xorg (__filemansuffix__)' on the commandline to cpp.
I figured the '' was useful for protecting us from shells that have special
handling of (), such as creating subshells to run commands in them.
At least for my testing on Solaris (with gmake, didn't try Solaris make),
it resulted in:
.SH "SEE ALSO"
.BR xinit (1),
.BR Xserver (1),
.BR Xorg (1),
.BR xorg.conf (4)
--
-Alan Coopersmith- [email protected]
Sun Microsystems, Inc. - X Window System Engineering
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel
