On Mon, 19 Oct 2009, Keith Packard wrote: > Excerpts from Yaakov (Cygwin/X)'s message of Mon Oct 19 12:38:15 +0900 2009: >> it would be safer to use CFLAGS. > > If you're not #including dix-config.h before any system headers, you're > doing it wrong. All of the server sources should include that before > anything else.
For that particular case, true. However, using AC_DEFINE for example to adjust definitions (using gcc as an example) which are tested in features.h and/or cdefs.h is a sure way to produce nonportable code. (I took a quick look at current git to see that this aspect is abused, and aside from noting that it's a problem with the code will not bother to list every occurrence). awai -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
