On Thu, Oct 29, 2009 at 6:16 AM, Mikhail Gusarov <dotted...@dottedmag.net> wrote: > > Twas brillig at 06:06:10 29.10.2009 UTC-07 when dbn.li...@gmail.com did gyre > and gimble: > > >> +libglxdri_la_LIBADD = @DLOPEN_LIBS@ > > DN> Is there a reason not to just use the variable $(DLOPEN_LIBS)? > > Use where? > > Do you just mean s/@DLOPEN_LIBS@/$(DLOPEN_LIBS)/g ?
Yes. The current patch will result in: Makefile: DLOPEN_LIBS = -ldl ... libglxdri_la_LIBADD = -ldl Since the variable is already in the Makefile, it would be nicer to use it. Makefile: DLOPEN_LIBS = -ldl ... libglxdri_la_LIBADD = $(DLOPEN_LIBS) It's both clearer what's going and allows flexibility (in corner cases) for zero cost. -- Dan _______________________________________________ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
