On Fri, 2009-11-13 at 21:52 +0100, Maarten Maathuis wrote: > 2009/11/12 Michel Dänzer <[email protected]>: > > On Mon, 2009-11-09 at 19:52 +0100, Maarten Maathuis wrote: > >> On Mon, Nov 9, 2009 at 12:14 AM, Maarten Maathuis <[email protected]> > >> wrote: > >> >> This is just an observation, but I do find the fact we have two things > >> >> > >> >> exaPixmapIsOffscreen(pPixmap) > >> >> and > >> >> !pExaPixmap->offscreen > >> >> > >> >> Like I know they are different but really seriously can anyone know > >> >> the difference just by reading this? > >> >> > >> >> EXA has become quite complicated recently and very difficult to trace > >> >> through, this naming doesn't help. > >> > >> exaPixmapIsOffscreen() is related to having a driver/vram/whatever pixmap > >> > >> pExaPixmap->offscreen says if the offscreen pixmap is the current > >> choice of rendering to > >> > >> The naming came from classic exa. Some better names might be: > >> > >> exaPixmapHasOffscreen() > > > > Rather something like exaIsGpuAccessible(). > > What about exaHasGpuCopy and ->use_gpu_copy?
Fine with me. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
