On Fri, Nov 27, 2009 at 10:39:15AM -0800, Dan Nicholson wrote: > On Fri, Nov 27, 2009 at 9:54 AM, Gaetan Nadon <[email protected]> > wrote: > > Thanks! That's an area I need to learn more about. I picked this line from > > other .ac files. I'll make it a todo when I review those to make the > > correction. I did replace "pkg-config" with the libtool env var in the hope > > it would be more portable and/or safer. > > > > sdkdir=$(pkg-config --variable=sdkdir xorg-server) > > This should be > > sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server` > > 1. The user may need to use a specific pkg-config or pass custom > arguments to it. Think multiarch or cross-compiling scenarios. > > 2. Backticks (``) are supported by all shells while $() command > substitution is for strictly POSIX conforming shells. We don't need to > limit ourselves to that subset.
Yeah, I wrote that bit originally, and those changes sound fine to me. Cheers, Daniel
pgpUKoGZCU5ob.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
