On Mon, Nov 30, 2009 at 08:56:58 +1000, Peter Hutterer wrote:

> xgeExtRegister is defined here but declared in extutil.c.
> 
> the gcc docs recommend adding attributes to the declaration:
> "The visibility attribute should be applied only to declarations which would
> otherwise have external linkage. [...]"
> http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes
> 
> I think it'd be better to move the attribute to extutil.c then. given that
> change,
> Acked-by: Peter Hutterer <[email protected]>
> 
I've made that change and pushed.  Thanks.

Cheers,
Julien
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to