On Nov 30, 2009, at 08:41, Keith Packard wrote: > On Mon, 30 Nov 2009 13:17:51 +0100, Michel Dänzer <[email protected]> wrote: > >> Not sure what I was thinking, turns out alloca() of a size derived from >> client >> input is a bad idea. > > That was the sole remaining use of alloca outside of the quartz > back-end. > > As a reminder to others -- alloca should never be used in the X server; > it cannot be relied upon to return NULL on failure, doing various things > From crashing the application to overwriting other parts of the > application.
Wow, I didn't even realize it was being used in XQuartz. alloca does return NULL on failure on OSX, so it's not as much of a problem here, but this should make things more consistent. I'll get you a patch in a few. --Jeremy
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
