On Tue, 2009-12-01 at 08:27 +1000, Dave Airlie wrote: > On Mon, 2009-11-30 at 17:09 -0500, Adam Jackson wrote: > > - pci_device_read_rom() almost certainly does not need the vgaarb lock. > > I suppose it _might_ if it's trying to grab the rom from 0xc0000, but > > that should really be handled internal to libpciaccess if true. > > On Linux the kernel shadows the 0xc0000 file and when you use /sys to > access the boot PCI rom it always gives you the 0xc0000 copy. > > So yes definitely inside libpciaccess. > > libpciaccess should not fall back to 0xc0000 access itself, unless > we are willing to say libpciaccess is only to be used for video cards.
Is it worth adding API to pciaccess to get at the legacy roms too? It's a slight bit of scope creep, but libx86 is going to need the 0xf0000 rom on IGP-style machines. Might as well hide all the mmap junk in one place. - ajax
signature.asc
Description: This is a digitally signed message part
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
