On Wed,  2 Dec 2009 11:48:11 +0100, Michel Dänzer <[email protected]> wrote:

> +     if (pSrc->pDrawable) {
> +         xSrc += pSrc->pDrawable->x;
> +         ySrc += pSrc->pDrawable->y;
> +     }
> +
> +     if (pMask && pMask->pDrawable) {
> +         xMask += pMask->pDrawable->x;
> +         yMask += pMask->pDrawable->y;
> +     }
> +

I haven't read through the code carefully yet, but if there are
transforms involved, then this computation is incorrect -- source
coordinates are in the post-transform space. Given that the next line
calls miComputeCompositeRegion, that would also be incorrect in the
presence of source or mask transforms (yay!).

-- 
[email protected]

Attachment: pgpz4HuJ4enwL.pgp
Description: PGP signature

_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to