Twas brillig at 16:04:50 04.01.2010 UTC+11 when [email protected] did gyre and gimble:
>> >> any particular reason this patch is needed? It touches a lot of files but >> >> doesn't actually improve the code. >> > >> > I checked with git diff -b and saw that it changed nothing; as it >> > just eliminates a pile of trailing white space. Makes it easier to >> > change the code in the future as you don't have to worry about >> > accidentally removing trailing whitespace and having diffs cluttered >> > with that. >> > >> > I'm in favor of this kind of cleanup; anyone else have an opinion? >> >> If it's done manually rather than mechanically, it'll be undone by >> another edit using cut/paste, etc. DS> echo 'let c_space_errors=1' >> ~/.vimrc DS> Or just let the reviewer pick it up. Or, or ... Yep, once fixed it won't be reintroduced so easily (and I did not see lots of trailing whitespace in other parts of X server). My intention was the one Keith mentioned: keep whitespace and functionality changes separate. -- http://fossarchy.blogspot.com/
pgp7tJHI6mMRf.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
