On Tue, Jan 05, 2010 at 06:18:14PM +0000, Julien Cristau wrote: > Hi, > > Debian's been carrying some changes to xdm since the xfree86 days, most > of them as part of a big "xdm_fixes.diff" patch with various unrelated > changes. A while ago I started splitting those changes up and trying to > figure out what was still possibly relevant, and Alan picked up some of > them which are included in 1.1.9. I'm getting tired of rebasing these > patches for each new upstream release, though, so I'd like to see what > can be made of the remainder of these changes. > > Matthieu, the old patch had this in the header: > > Submitted upstream to Matthieu Herrb on 2003-09-24. > + except for latest changes to genauth.c and session.c, which were > submitted to Matthieu Herrb on 2003-10-14 > > Do you remember what happened with this, and did you maintain an xdm > tree somewhere?
Only vaguely. This was in the last months of XFree86, so if I committed those patches somewhere it should be in the XFree86 4.4 beta. But I may have slacked on those partches and not have committed before XFree86 collapsed. > For some of the patches I'm not sure of the attribution. The old patch > listed Branden Robinson, Matthieu Herrb, and Richard Braakman as > authors. I could try to dig old mailboxes, but without any guaranty that I still have those messages (they are archived on CDs somewhere in my office at work). Otherwise: Reviewed-by: Matthieu Herrb <[email protected]> Just one remark for patch 4 (appending to the log file instead of truncating it): this will probably require to do something to rotate the log file with other logs... but can xdm re-open it after rotation? > > Cheers, > Julien > > Branden Robinson (7): > downgrade an error to info message > Change openFiles() to avoid race-based symlink attacks. > Always attempt to write data to the auth file > improve error logging > Improve logging of xdm's script handling > add support for logfile rotation > rewrite StorePid() > > Julien Cristau (2): > Add timestamping to logging functions > Append to the log file instead of truncating it > > Manoj Srivastava (1): > xdm: add SELinux support > > auth.c | 85 +++++++++++++++++++++++++++++---- > configure.ac | 17 +++++++ > dm.c | 148 > ++++++++++++++++++++++++++++++++++++++-------------------- > dm_error.h | 2 + > error.c | 25 ++++++++-- > session.c | 89 ++++++++++++++++++++++++++++++----- > xdm.man.cpp | 31 ++++++++++++ > 7 files changed, 318 insertions(+), 79 deletions(-) > -- Matthieu Herrb _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
